Accept SciTokens-profile JWT #2223
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h2zh
added
bug
turetske
requested changes
Apr 22, 2025
client/main_test.go
Outdated
| @@ -497,3 +505,61 @@ func TestParseRemoteAsPUrl(t *testing.T) { | |||
| }) | |||
| } | |||
| } | |||
|
|
|||
| // mustURL parses a string into *url.URL or fails the test. | |||
| func mustURL(t *testing.T, s string) *url.URL { | |||
There was a problem hiding this comment.
It seems very odd to have this as a separate function for something that is only used once. Why isn't this check done before the dirResp assignment and then have the result places in the slice rather than doing a separate function.
There was a problem hiding this comment.
My bad. That's an overthinking. Just reorganized the code.
- as it does for WLCG tokens
h2zh
force-pushed
the
verify-scitokens-jwt
branch
from
91ba8d7 to
82390ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pelican’s client today only recognizes WLCG tokens (i.e. JWTs with a wlcg.ver claim). When a user supplies a SciTokens‑profile JWT (with ver: "scitokens:2.0"), Pelican will reject it as “unacceptable”. This PR extends the token profiles Pelican support from WLCG to SciTokens. Check out the linked issue for more details.
Close #2130