Ensure test is properly shut down on failure #2258
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this, if the test fails, various goroutines stick around and can prevent the unit test framework from a clean shutdown.
jhiemstrawisc
approved these changes
Apr 30, 2025
Comment on lines
207
to
210
| if err != nil { | ||
| f.FedCancel() | ||
| f.T.Fatalf("Failure in fedServeInternal: %v", err) | ||
| } |
There was a problem hiding this comment.
I think this works, but out of curiosity why not do:
_, f.FedCancel, err = launchers.LaunchModules(ctx, modules)
require.NoError(t, err, "Failure to launch federation")
If I understand correctly, the issue with f.T.Fatal() is that it shuts down immediately, preventing the deferred Teardown() function from running. None of the other error checks we do after launching modules in Spinup() seem to need an explicit call to FedCancel(), and I think it's because require.NoError() doesn't prevent the teardown.
jhiemstrawisc
added
test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this, if the test fails, various goroutines stick around and can prevent the unit test framework from a clean shutdown.