Improve the error messages for when the user provides a bad password

[bbockelm]

Captures the underlying package's text-based error and converts it to a first-class named error, allowing us to test with errors.Is(...).

[h2zh]

Approve with optional suggestion.

I think the "how to reset password" prompt should also be added to printConfig func, when password error is detected.

[h2zh]

Maybe we can use a helper function? For example:

func printPasswordError(err error, actionText string) {
	if errors.Is(err, config.ErrIncorrectPassword) {
		fmt.Fprintf(os.Stderr, "Failed to %s - entered incorrect local decryption password\n", actionText)
		fmt.Fprintln(os.Stderr, "If you have forgotten your password, you can reset the local state (deleting all on-disk credentials)")
		fmt.Fprintf(os.Stderr, "by running '%s credentials reset-local'\n", os.Args[0])
        os.Exit(1)
	} 
}

[aowen-uwmad]

I second creating a helper function, so changes to the text are consistent.

I also suggest adjusting the text like so:

- fmt.Fprintf(os.Stderr, "Failed to %s - entered incorrect local decryption password\n", actionText)
+ fmt.Fprintf(os.Stderr, "Failed to %s - password is incorrect\n", actionText)

[aowen-uwmad]

If password is incorrect is too vague, then maybe password for local credentials is incorrect.

[jhiemstrawisc]

Pinging @aowen-uwmad on this since I think this has a lot of overlap with #2793 -- can we knock out both with one PR?

[aowen-uwmad]

@jhiemstrawisc , here's what I propose (#2793 (comment)):

The message prompt for creating a new password should be

Please create a new password to protect your local credentials:

and the message prompt for entering the password should be

Please enter the password you created to protect your local credentials: