Handle legacy Capability name gracefully #2841
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- When an Origin/Cache running Pelican before v7.22.0, they are advertising with the old names. This commit converts them into the new ones
h2zh
added
origin
- Update the names in `Capabilities` interface - Conversion is done in backend, so the frontend doesn't need to map the old names to new ones
h2zh
force-pushed
the
capabilities-name
branch
from
8652167 to
9bfc218
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We adopted new capability naming convention (PublicReads, Reads, Writes, Listings, DirectReads) ~2 years ago, but the JSON tags were left with the old names (PublicRead, Read, Write, Listing, FallBackRead). The conversion is done on the frontend, which is not a desirable approach.
Solution
This PR move the capability name conversion from frontend to backend.
I hand tested this PR for backward compatibility by spinning up the Director, Registry in this branch, and Origin in main. It stimulates a Origin <= v7.21 sending ads with old capability names to 7.22 Director.