Fix token discovery logic #2846
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixed bug in tests - Added token location tracking - Refactored token accebility policy
patrickbrophy
added
bug
turetske
requested changes
Dec 16, 2025
|
|
||
| // matchesResource checks if the target resource matches the scope resource. | ||
| // For shared URLs, exact matches are preferred, but prefix matching is also acceptable. | ||
| func matchesResource(targetResource, scopeResource string, operation config.TokenOperation) bool { |
Collaborator
There was a problem hiding this comment.
It would be nice to have unit tests for these helper functions. Helps identify more specifically when/if we introduce bugs that cause token verification issues.
| } | ||
|
|
||
| // Verify if a scitoken‐profile JWT is acceptable for a given namespace | ||
| func TestTokenIsAcceptableForSciTokens(t *testing.T) { |
Collaborator
There was a problem hiding this comment.
Looking at this because you altered the test. This really feels like it should be in acquire_token_test.go file rather than main.
| strings.HasPrefix(targetNorm, scopeNorm) | ||
| } | ||
|
|
||
| func isValidWLCGScope(authz string, operation config.TokenOperation) bool { |
| } | ||
| } | ||
|
|
||
| func isValidSciScope(authz string, operation config.TokenOperation) bool { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2812 - Token discovery was incorrectly rejecting valid SciTokens and logging empty token location. The cause of this was that token validation only checked for WLCG tokens, causing valid SciTokens to be incorrectly flagged as unacceptable.