Fix checksum logic in pelican object stat
#2847
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turetske
requested changes
Dec 16, 2025
Collaborator
turetske
left a comment
turetske
left a comment
There was a problem hiding this comment.
I have some clarifying questions, just so I understand the fix.
| delete(remaining, info.Algorithm) | ||
| collected = true | ||
| } | ||
| if len(remaining) == 0 { |
Collaborator
There was a problem hiding this comment.
Just to clarify more my own understanding, since you only delete info.Algorithm from remaining when there is no checksumErr, this is only true if all the checksums have evaluated with no error?
| if checksumErr == nil { | ||
| checksumErr = errors.New("no checksum data returned by server") | ||
| } | ||
| err = errors.Wrap(checksumErr, "failed to fetch checksums") |
Collaborator
There was a problem hiding this comment.
Will this mean if the server doesn't have checksumming, this will throw an error? Or is there a check higher up in the algorithm I can't see due to the nature of the PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2827. When running
pelican object stat --checksums sha, the client would display what checksum the server returned without any indication that the requested checksum type wasn't provided. Now we track the requested checksums and track that they are satisfied. We now log a warning when the requested checksum types are not returned by the server.