Add support for admin groups #2863
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickbrophy
added
enhancement
Collaborator
|
Small nitpick: I know we've historically called it the "UI" but it's evolved well beyond that. Even if it's not entirely consistent with other knobs, let's call it AdminGroups (or some variant of that). |
h2zh
requested changes
Dec 16, 2025
Co-authored-by: Howard Zhong <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2838. This PR adds a new configuration parameter,
Server.UIAdminGroups. With this new parameter it is possible to specify admin groups. This PR also adds tests to ensure that the behavior is correct.