Move PELICAN_MAXMINDKEY config handling into config package and deprecate #2883
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cate Setting the MaxMind key file via this env var pre-dates Pelican being Pelican, and it looks like this config handling never made it into the config package. This commit moves its handling into our config package and tests that the binding still happens and with the correct precedence.
jhiemstrawisc
added
director
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting the MaxMind key file via this env var pre-dates Pelican being Pelican, and it looks like handling for this configuration never fully made it into the config package.
This PR moves the environment variable handling into the config package and logs a deprecation warning when users configure it.