Update the type of server when its service gets deleted #2902
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h2zh
added
bug
Updated server deletion flow to keep server flags in sync: after removing a registration, remaining services are inspected and is_origin/is_cache are recalculated; the server is only deleted when no services remain.
h2zh
force-pushed
the
delete-ns-update-server
branch
from
d7cd13d to
8ca55d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated server deletion flow to keep server flags in sync in
serverstable: after removing a registration, remaining services are inspected and is_origin/is_cache are recalculated; the server entry will be deleted when no services remain as before.This bug only affect the servers that are being both origin and cache, which are not exist in production.