Conflict error fix #129
Open
Conflict error fix #129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… url -- Created an _ls_from_https which monkeypatches the http file system's _ls -- Now ALL list calls will go to a collections URL -- Also added cacheing of the collections URL in the director response to prevent constant director calls
-- Added tests which ensure the readme examples work -- Added tests of 'get' functionality -- Updated namespace_info tests to clear the namespace info cache between tests
patrickbrophy
requested changes
Dec 19, 2025
Comment on lines
+644
to
+645
| if namespace not in self._namespace_cache: | ||
| self._namespace_cache[namespace] = _CacheManager([], director_response) |
There was a problem hiding this comment.
If a namespace already exists in _namespace_cache but has no director_response yet, you silently skip updating it. That can leave stale or incomplete namespace metadata in place.
There was a problem hiding this comment.
My issue with these integration is that:
- They depend on live OSDF infrastructure
- Failures may be due to network, not code
I am not suggesting to get rid of them but to maybe make them optional
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #128
Closes #47
This fix implements an _ls_from_https calls which ensures that any ls call from https will be redirected to the appropriate collections url.
This code also reduces the number of director calls to get the collections url by caching that information as part of the namespace-info structure to be reused when we have prefix matches.