Skip to content

Refine subcommand pipelines - #14

Merged
Ulthran merged 2 commits into
mainfrom
codex/add-counters-for-input/output-reads
Sep 29, 2025
Merged

Refine subcommand pipelines#14
Ulthran merged 2 commits into
mainfrom
codex/add-counters-for-input/output-reads

Conversation

@Ulthran

@Ulthran Ulthran commented Sep 29, 2025

Copy link
Copy Markdown
Contributor

Summary

  • adjust _run_paired_command to take a pipeline builder and reuse functools.partial when invoking it
  • simplify each subcommand by directly passing its pipeline into the shared runner and extract a helper for trim-quality chaining

Testing

  • python -m compileall src

https://chatgpt.com/codex/tasks/task_e_68dae3410b148323ab279fe828358255

Copilot AI review requested due to automatic review settings September 29, 2025 20:07

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the command structure to use a shared pipeline runner pattern with functools.partial for better code reuse and maintainability. The refactoring introduces a unified approach for handling paired FASTQ command processing with built-in statistics tracking.

  • Introduces _run_paired_command function that handles common pipeline execution with input/output statistics
  • Extracts _trim_quality_pipeline helper function to encapsulate the complex trimming logic
  • Simplifies all subcommand functions to use the shared runner with partial function application

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread src/heyfastqlib/command.py
@Ulthran
Ulthran merged commit c921e2e into main Sep 29, 2025
4 checks passed
@Ulthran
Ulthran deleted the codex/add-counters-for-input/output-reads branch September 29, 2025 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants