Add Assembly table views - #21
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a comprehensive set of Assembly-related views to the application, including both UI templates and API endpoints. It introduces a new Assembly dropdown menu in the navigation to organize related functionality.
- Adds four new browse templates for assemblies, assembly QC, taxonomic assignments, and antimicrobials
- Creates corresponding API endpoints to serve data for these tables
- Updates navigation with a dropdown menu structure for Assembly-related views
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| app/app.py | Adds 8 new routes (4 browse views + 4 API endpoints) for assembly-related data |
| app/templates/base.html | Updates navigation to include Assembly dropdown menu with 4 sub-items |
| app/templates/browse_assemblies.html | New template for displaying assemblies table with 9 columns |
| app/templates/browse_assembly_qc.html | New template for assembly QC data with 12 columns |
| app/templates/browse_taxonomic_assignments.html | New template for taxonomic assignment data with 7 columns |
| app/templates/browse_antimicrobials.html | New template for antimicrobial data with 8 columns |
| tests/test_api.py | Adds parameterized test covering all 4 new page/API endpoint pairs |
Comments suppressed due to low confidence (1)
app/app.py:127
- The Assembly, AssemblyQC, TaxonomicAssignment, and Antimicrobial model imports are not visible in this diff. Ensure these models are properly imported at the top of the file to avoid NameError exceptions.
return datatables_response(select(Assembly))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
black .pytest tests/https://chatgpt.com/codex/tasks/task_e_687e925d2ce48323b6fdcf80bc2ef3ae