Skip to content

Add Assembly table views - #21

Merged
Ulthran merged 1 commit into
mainfrom
codex/add-prebuilt-views-for-assembly-tables
Jul 21, 2025
Merged

Add Assembly table views#21
Ulthran merged 1 commit into
mainfrom
codex/add-prebuilt-views-for-assembly-tables

Conversation

@Ulthran

@Ulthran Ulthran commented Jul 21, 2025

Copy link
Copy Markdown
Contributor

Summary

  • add dropdown Assembly menu
  • create browse templates for assembly-related tables
  • expose new routes and API endpoints
  • test new pages

Testing

  • black .
  • pytest tests/

https://chatgpt.com/codex/tasks/task_e_687e925d2ce48323b6fdcf80bc2ef3ae

Copilot AI review requested due to automatic review settings July 21, 2025 20:22

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a comprehensive set of Assembly-related views to the application, including both UI templates and API endpoints. It introduces a new Assembly dropdown menu in the navigation to organize related functionality.

  • Adds four new browse templates for assemblies, assembly QC, taxonomic assignments, and antimicrobials
  • Creates corresponding API endpoints to serve data for these tables
  • Updates navigation with a dropdown menu structure for Assembly-related views

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
app/app.py Adds 8 new routes (4 browse views + 4 API endpoints) for assembly-related data
app/templates/base.html Updates navigation to include Assembly dropdown menu with 4 sub-items
app/templates/browse_assemblies.html New template for displaying assemblies table with 9 columns
app/templates/browse_assembly_qc.html New template for assembly QC data with 12 columns
app/templates/browse_taxonomic_assignments.html New template for taxonomic assignment data with 7 columns
app/templates/browse_antimicrobials.html New template for antimicrobial data with 8 columns
tests/test_api.py Adds parameterized test covering all 4 new page/API endpoint pairs
Comments suppressed due to low confidence (1)

app/app.py:127

  • The Assembly, AssemblyQC, TaxonomicAssignment, and Antimicrobial model imports are not visible in this diff. Ensure these models are properly imported at the top of the file to avoid NameError exceptions.
    return datatables_response(select(Assembly))

@Ulthran
Ulthran merged commit 675313a into main Jul 21, 2025
6 checks passed
@Ulthran
Ulthran deleted the codex/add-prebuilt-views-for-assembly-tables branch July 21, 2025 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants