Skip to content

Use Gaussian interpolation for resampling tissue probability maps #542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 26, 2025

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented May 23, 2025

Closes none.

Changes proposed in this pull request

  • Replace NearestNeighbor interpolation with Gaussian interpolation for resampling tissue probability maps, to match sMRIPrep's approach.
  • Replace LanczosWindowedSinc interpolation with Gaussian interpolation for resampling CBF maps. This doesn't match what other tools do, but it may make more sense for CBF maps where we expect positive values.
    • I might try adding this in a separate PR.

@tsalo tsalo added the enhancement New feature or request label May 23, 2025
Copy link
Contributor

@effigies effigies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding a note that this is consistent with smriprep's resampling strategy for tissue probability maps.

@codecov-commenter
Copy link

codecov-commenter commented May 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.86%. Comparing base (a1280d1) to head (3cd2a3b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #542   +/-   ##
=======================================
  Coverage   82.86%   82.86%           
=======================================
  Files          38       38           
  Lines        4079     4079           
=======================================
  Hits         3380     3380           
  Misses        699      699           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tsalo tsalo added the nipreps Maintains consistency with the rest of the nipreps ecosystem (especially fMRIPrep). label May 26, 2025
@tsalo tsalo changed the title Try out Gaussian interpolation Use Gaussian interpolation for resampling tissue probability maps May 26, 2025
@tsalo tsalo marked this pull request as ready for review May 26, 2025 13:13
@tsalo tsalo merged commit 7254203 into main May 26, 2025
26 checks passed
@tsalo tsalo deleted the tpm-resampling branch May 26, 2025 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request nipreps Maintains consistency with the rest of the nipreps ecosystem (especially fMRIPrep).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants