Skip to content

Conversation

@tsalo
Copy link
Member

@tsalo tsalo commented Jul 25, 2025

Closes #255.

Changes proposed in this pull request

  • Rather than raising a warning if an atlas isn't collected properly, raise an exception.

@tsalo tsalo added the enhancement New feature or request label Jul 25, 2025
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 12.92%. Comparing base (f6b40c0) to head (39d6216).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
qsirecon/utils/atlases.py 0.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #256      +/-   ##
==========================================
- Coverage   12.93%   12.92%   -0.02%     
==========================================
  Files          56       56              
  Lines        7899     7907       +8     
  Branches     1071     1072       +1     
==========================================
  Hits         1022     1022              
- Misses       6845     6853       +8     
  Partials       32       32              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tsalo tsalo requested a review from mattcieslak July 25, 2025 14:10
@tsalo
Copy link
Member Author

tsalo commented Jul 25, 2025

@mckenziephagen would you mind taking a look at this PR to see if it resolves your issue?

@tsalo tsalo marked this pull request as ready for review July 25, 2025 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Check for valid atlas before running

3 participants