Skip to content

Conversation

@tsalo
Copy link
Member

@tsalo tsalo commented Oct 29, 2025

Relates to #274.

Changes proposed in this pull request

  • Assign original LUT to original LUT output and MRTRIX3 LUT to MRTRIX3 LUT output.
  • Write out original LUT and MRTRIX3 LUT as separate files (they were being writtent to the same location, so one was overwriting the other).

@tsalo tsalo added the bug Something isn't working label Oct 29, 2025
@cursor
Copy link

cursor bot commented Oct 29, 2025

You have run out of free Bugbot PR reviews for this billing cycle. This will reset on November 20.

To receive reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

Comment on lines -103 to +104
atlas_configs[atlas_name]["orig_lut"] = output_mif_txt
atlas_configs[atlas_name]["mrtrix_lut"] = output_orig_txt
atlas_configs[atlas_name]["orig_lut"] = output_orig_txt
atlas_configs[atlas_name]["mrtrix_lut"] = output_mif_txt
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the main bit.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦

@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 12.88%. Comparing base (23b6524) to head (64c3361).

Files with missing lines Patch % Lines
qsirecon/interfaces/utils.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #278   +/-   ##
=======================================
  Coverage   12.88%   12.88%           
=======================================
  Files          56       56           
  Lines        7929     7929           
  Branches     1076     1076           
=======================================
  Hits         1022     1022           
  Misses       6875     6875           
  Partials       32       32           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants