Skip to content

Finalize BIDS Atlas compliance#1584

Merged
tsalo merged 44 commits intomainfrom
bids-atlas-update
Feb 17, 2026
Merged

Finalize BIDS Atlas compliance#1584
tsalo merged 44 commits intomainfrom
bids-atlas-update

Conversation

@tsalo
Copy link
Member

@tsalo tsalo commented Feb 13, 2026

Closes #1540.

Changes proposed in this pull request

  • Move built-in atlases (Glasser, Gordon, Tian, Myers-Labonte, MIDB) into base Docker image.
  • Modify collect_atlases to support fully-BIDS-compliant atlases.

Documentation that should be reviewed

@tsalo tsalo added the nipreps Issues/PRs related to keeping XCP-D in line with the NiPreps ecosystem. label Feb 17, 2026
@codecov
Copy link

codecov bot commented Feb 17, 2026

Codecov Report

❌ Patch coverage is 83.82353% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.87%. Comparing base (72555de) to head (c954c5a).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
xcp_d/interfaces/bids.py 80.39% 4 Missing and 6 partials ⚠️
xcp_d/utils/atlas.py 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1584      +/-   ##
==========================================
- Coverage   82.91%   82.87%   -0.05%     
==========================================
  Files          58       58              
  Lines        7886     7924      +38     
  Branches     1124     1130       +6     
==========================================
+ Hits         6539     6567      +28     
- Misses       1011     1015       +4     
- Partials      336      342       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tsalo tsalo requested a review from Copilot February 17, 2026 18:41
@tsalo tsalo marked this pull request as ready for review February 17, 2026 18:43
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request implements BIDS Atlas v1.11.0 compliance for XCP-D, addressing issue #1540. The changes reorganize atlas file structure and naming conventions to align with the recently finalized BIDS Atlas specification.

Changes:

  • Moved built-in atlases (Glasser, Gordon, Tian, Myers-Labonte, MIDB, HCP) from package data to base Docker image (version 0.0.24)
  • Updated BIDS entity names: segmentationatlas, spacetemplate (tpl)
  • Changed atlas TSV column name from labelname per BIDS v1.11.0
  • Reorganized output structure: atlases/derivatives/atlases/tpl-<label>/
  • Updated DatasetType from atlasderivative in dataset_description.json
  • Added new CopyAtlasDescription interface to copy atlas description files

Reviewed changes

Copilot reviewed 45 out of 55 changed files in this pull request and generated no comments.

Show a summary per file
File Description
xcp_d/interfaces/bids.py Added CopyAtlasDescription interface; updated CopyAtlas to use tpl/atlas entities
xcp_d/workflows/parcellation.py Added atlas_dataset_paths tracking; updated output directory to derivatives/atlases
xcp_d/workflows/bold/outputs.py Changed entity from 'segmentation' to 'atlas' in DerivativesDataSink calls
xcp_d/workflows/anatomical/parcellation.py Changed entity from 'segmentation' to 'atlas'
xcp_d/interfaces/connectivity.py Updated to use 'name' column instead of 'label' from atlas TSV files
xcp_d/utils/atlas.py Changed filter from 'space' to 'template'; updated TSV column validation
xcp_d/utils/bids.py Changed DatasetType from 'atlas' to 'derivative'
xcp_d/data/_bids_config.json Updated entity patterns and path patterns for new naming scheme
xcp_d/cli/* Updated atlas output path to derivatives/atlases
xcp_d/tests/* Updated test paths to new naming convention
docs/*.rst Updated documentation to reflect BIDS v1.11.0 structure
Dockerfile Bumped base image to 0.0.24 with built-in atlases
xcp_d/data/atlases/* Removed all built-in atlas files (moved to Docker image)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@tsalo tsalo merged commit 66acecc into main Feb 17, 2026
30 checks passed
@tsalo tsalo deleted the bids-atlas-update branch February 17, 2026 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

nipreps Issues/PRs related to keeping XCP-D in line with the NiPreps ecosystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Adopt BIDS Atlas organization

2 participants

Comments