Eliminate clang-tidy dependency

[dime10]

This is just a proposal, let me know if there are any objections :)

With lightning devices migrated out of Catalyst, the only remaining code affected by the clang-tidy option is the OpenQASM device code. The option is also disabled by default and not run in any CI scripts, so I propose to remove it entirely for simplicity.

[github-actions]

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md on your branch with:

• A one-to-two sentence description of the change. You may include a small working example for new features.
• A link back to this PR.
• Your name (or GitHub username) in the contributors section.

[mlxd]

I assumed the audit PR was enabling this for WAE. I'd rather we enable CT for the runtime, and wherever else if possible.
I can undelete my PR to add this into the pipeline.

Update: Reopened #1098

[dime10]

I assumed the audit PR was enabling this for WAE.

They are orthogonal features no? My understanding is clang-tidy is more like a linter?

I'd rather we enable CT for the runtime, and wherever else if possible.

Sounds good, if you'd rather build out the clang-tidy support that's fair (in the current state it was just useless, hence the PR).
Personally I would be cautious of "over-linting" (from our experience with pylint and codefactor leading to a lot of wasted time), but if we're selective about the rules than I would be in favour :)

[mlxd]

I assumed the audit PR was enabling this for WAE.

They are orthogonal features no? My understanding is clang-tidy is more like a linter?

I'd rather we enable CT for the runtime, and wherever else if possible.

Sounds good, if you'd rather build out the clang-tidy support that's fair (in the current state it was just useless, hence the PR). Personally I would be cautious of "over-linting" (from our experience with pylint and codefactor leading to a lot of wasted time), but if we're selective about the rules than I would be in favour :)

Sure thing. All the rules are in https://github.com/PennyLaneAI/guidance-docs/blob/master/config_files/.clang-tidy already with the reasoning in the associated dev docs :)