Add resource tracking to NullQubit #1619
Open
+255
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1619 +/- ##
==========================================
+ Coverage 96.51% 96.58% +0.07%
==========================================
Files 82 82
Lines 9029 9158 +129
Branches 861 861
==========================================
+ Hits 8714 8845 +131
+ Misses 258 256 -2
Partials 57 57 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Oh wow, I was just starting on this as well a couple of hours ago (just as a hack) 😆 Super useful though, thanks! |
maliasadi
reviewed
Apr 10, 2025
dime10
reviewed
Apr 10, 2025
…nstead of destructor
… CIs from running
…alyst into feature/complexity-stats
jzaia18
changed the title
…alyst into feature/complexity-stats
github-merge-queue bot
pushed a commit
to PennyLaneAI/pennylane
that referenced
this pull request
May 5, 2025
**Context:** PR #7226 added a resource-tracking feature to PennyLane. The same feature is desired in Catalyst: PennyLaneAI/catalyst#1619 **Description of the Change:** Adds a class attribute to `null.qubit` which allows the `resource_tracking` argument to get passed through to Catalyst. **Benefits:** `track_resources` can more cleanly be passed through to Catalyst. **Possible Drawbacks:** **Related GitHub Issues:** #7226 PennyLaneAI/catalyst#1619 PennyLaneAI/pennylane-benchmarks#76 [sc-88213](https://app.shortcut.com/xanaduai/story/88213) --------- Co-authored-by: Ali Asadi <[email protected]>
austingmhuang
pushed a commit
to PennyLaneAI/pennylane
that referenced
this pull request
May 6, 2025
**Context:** PR #7226 added a resource-tracking feature to PennyLane. The same feature is desired in Catalyst: PennyLaneAI/catalyst#1619 **Description of the Change:** Adds a class attribute to `null.qubit` which allows the `resource_tracking` argument to get passed through to Catalyst. **Benefits:** `track_resources` can more cleanly be passed through to Catalyst. **Possible Drawbacks:** **Related GitHub Issues:** #7226 PennyLaneAI/catalyst#1619 PennyLaneAI/pennylane-benchmarks#76 [sc-88213](https://app.shortcut.com/xanaduai/story/88213) --------- Co-authored-by: Ali Asadi <[email protected]>
maliasadi
reviewed
May 7, 2025
Co-authored-by: Ali Asadi <[email protected]>
Co-authored-by: Ali Asadi <[email protected]>
Co-authored-by: Ali Asadi <[email protected]>
…alyst into feature/complexity-stats
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
For benchmarking, we need a method of precise resource tracking. This method has to be compatible with code run directly from PennyLane and should be able to track precise resources after various transformation passes have already occurred.
See also: https://github.com/PennyLaneAI/pennylane-benchmarks/pull/76 and PennyLaneAI/pennylane#7226
Description of the Change:
Adds 2 new class attributes to
NullQubit, as well as an optional argument to its constructor. When this option is toggled on,NullQubitwill track precise gate counts while "executing" a circuit and save them to a file when all qubits are released.Benefits:
It is now possible to track precise gate counts (with or without gate decomposition or other transformation passes) for measuring circuit complexity.
Possible Drawbacks:
This implementation currently write the resources JSON to a file on disk as opposed to neatly returning an object back through to the Python caller in PennyLane. In the future, a more robust solution may be desired.
Related GitHub Issues:
[sc-88213]