Rename of operands/attributes to avoid xDSL reserved keywords #1700
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paul0403
reviewed
May 1, 2025
| @@ -619,11 +619,11 @@ def YieldOp : Quantum_Op<"yield", [Pure, ReturnLike, Terminator, ParentOneOf<["A | |||
| let summary = "Return results from quantum program regions"; | |||
|
|
|||
| let arguments = (ins | |||
| Variadic<QuregType>:$results | |||
| Variadic<QuregType>:$retvals | |||
|
Hello. You may have forgotten to update the changelog!
|
sengthai
approved these changes
May 9, 2025
There was a problem hiding this comment.
Thanks Erick for PR. 🥳 I left some comments here
I feel that dev_name may seem a little unclear, but using the full term, such as device_name might make it more straightforward. I'm not sure whether that name includes any reserved keywords.
But no worries! If you like dev_name, it's absolutely fine to stick with that! 😅
| @@ -85,12 +85,12 @@ def DeviceInitOp : Quantum_Op<"device"> { | |||
| let arguments = (ins | |||
| Optional<I64>:$shots, | |||
| StrAttr:$lib, | |||
| StrAttr:$name, | |||
| StrAttr:$dev_name, | |||
There was a problem hiding this comment.
Suggested change
| StrAttr:$dev_name, | |
| StrAttr:$device_name, |
| StrAttr:$kwargs | ||
| ); | ||
|
|
||
| let assemblyFormat = [{ | ||
| (`shots` `(` $shots^ `)`)? `[` $lib `,` $name `,` $kwargs `]` attr-dict | ||
| (`shots` `(` $shots^ `)`)? `[` $lib `,` $dev_name `,` $kwargs `]` attr-dict |
There was a problem hiding this comment.
Suggested change
| (`shots` `(` $shots^ `)`)? `[` $lib `,` $dev_name `,` $kwargs `]` attr-dict | |
| (`shots` `(` $shots^ `)`)? `[` $lib `,` $device_name `,` $kwargs `]` attr-dict |
| @@ -391,7 +391,7 @@ FlatSymbolRefAttr ZneLowering::getOrInsertFoldedCircuit(Location loc, PatternRew | |||
|
|
|||
| Operation *shots = deviceInitOp.getShots().getDefiningOp(); | |||
| StringAttr lib = deviceInitOp.getLibAttr(); | |||
| StringAttr name = deviceInitOp.getNameAttr(); | |||
| StringAttr name = deviceInitOp.getDevNameAttr(); | |||
There was a problem hiding this comment.
Suggested change
| StringAttr name = deviceInitOp.getDevNameAttr(); | |
| StringAttr name = deviceInitOp.getDeviceNameAttr(); |
| @@ -196,7 +196,7 @@ struct DeviceInitOpPattern : public OpConversionPattern<DeviceInitOp> { | |||
| catalyst::ensureFunctionDeclaration(rewriter, op, qirName, qirSignature); | |||
|
|
|||
| auto rtd_lib = op.getLib().str(); | |||
| auto rtd_name = op.getName().str(); | |||
| auto rtd_name = op.getDevName().str(); | |||
There was a problem hiding this comment.
Suggested change
| auto rtd_name = op.getDevName().str(); | |
| auto rtd_name = op.getDeviceName().str(); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
Description of the Change:
Benefits:
Possible Drawbacks:
Related GitHub Issues: