-
Notifications
You must be signed in to change notification settings - Fork 47
Update clang-format and clang-tidy dependancy #1721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1721 +/- ##
=======================================
Coverage 96.51% 96.51%
=======================================
Files 82 82
Lines 9028 9029 +1
Branches 861 861
=======================================
+ Hits 8713 8714 +1
Misses 258 258
Partials 57 57 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Just an FYI, we may want to unify this with Lightning and the ruleset in the guidance repo. |
Made a PR for lightning and guidance as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Context:
As part of updating dependancy versions for the ecosystem, we want to update formatting tools like
clang-tidy
andclan-format
.Description of the Change:
Bump
clang-tidy
andclang-format
to v20.Note that I changed the Formatting CI job to install clang-format from the requirements this makes the job consistent with local development environment and allow us to use the latest version that are not yet available on the ubuntu repositories.
Benefits:
Using the latest formatting tools
Possible Drawbacks:
Related GitHub Issues:
[sc-91016]