Skip to content

Update clang-format and clang-tidy dependancy #1721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
May 12, 2025

Conversation

mehrdad2m
Copy link
Contributor

@mehrdad2m mehrdad2m commented May 6, 2025

Context:
As part of updating dependancy versions for the ecosystem, we want to update formatting tools like clang-tidy and clan-format.

Description of the Change:
Bump clang-tidy and clang-format to v20.

Note that I changed the Formatting CI job to install clang-format from the requirements this makes the job consistent with local development environment and allow us to use the latest version that are not yet available on the ubuntu repositories.

Benefits:
Using the latest formatting tools

Possible Drawbacks:

Related GitHub Issues:
[sc-91016]

Copy link

codecov bot commented May 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.51%. Comparing base (0fed865) to head (9051cf6).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1721   +/-   ##
=======================================
  Coverage   96.51%   96.51%           
=======================================
  Files          82       82           
  Lines        9028     9029    +1     
  Branches      861      861           
=======================================
+ Hits         8713     8714    +1     
  Misses        258      258           
  Partials       57       57           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mlxd
Copy link
Member

mlxd commented May 7, 2025

Just an FYI, we may want to unify this with Lightning and the ruleset in the guidance repo.

@mehrdad2m
Copy link
Contributor Author

mehrdad2m commented May 8, 2025

Just an FYI, we may want to unify this with Lightning and the ruleset in the guidance repo.

Made a PR for lightning and guidance as well.
PennyLaneAI/pennylane-lightning#1153
https://github.com/PennyLaneAI/guidance-docs/pull/67

@mehrdad2m mehrdad2m changed the title [WIP] Update clang-format and clang-tidy dependancy Update clang-format and clang-tidy dependancy May 8, 2025
@mehrdad2m mehrdad2m requested a review from a team May 8, 2025 20:14
Copy link
Contributor

@dime10 dime10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mehrdad2m mehrdad2m merged commit f854d83 into main May 12, 2025
41 checks passed
@mehrdad2m mehrdad2m deleted the bump_clang_format-tidy-version branch May 12, 2025 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants