Skip to content

Clean some unused leftover headers in pipelines.cpp#2733

Merged
paul0403 merged 3 commits intomainfrom
pipeline_header_clean
Apr 22, 2026
Merged

Clean some unused leftover headers in pipelines.cpp#2733
paul0403 merged 3 commits intomainfrom
pipeline_header_clean

Conversation

@paul0403
Copy link
Copy Markdown
Member

@paul0403 paul0403 commented Apr 22, 2026

Context:
#2259 removed the pipeline definition from mlir/lib/Driver/pipelines.cpp, to have a single source of truth pipeline registry 🥳

There are some left over dialect and pass headers that are no longer needed.

Description of the Change:
Delete unused headers.

Benefits:
Cleaner code.

@paul0403 paul0403 requested review from a team, dime10, joeycarter and mehrdad2m April 22, 2026 16:33
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.07%. Comparing base (96b34bc) to head (798a01f).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2733   +/-   ##
=======================================
  Coverage   97.07%   97.07%           
=======================================
  Files         164      164           
  Lines       18703    18703           
  Branches     1766     1766           
=======================================
  Hits        18156    18156           
  Misses        397      397           
  Partials      150      150           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

@dime10 dime10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@paul0403 paul0403 merged commit ca2c62b into main Apr 22, 2026
51 of 52 checks passed
@paul0403 paul0403 deleted the pipeline_header_clean branch April 22, 2026 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants