Skip to content

Add catalyst.memspace attribute#2750

Open
mehrdad2m wants to merge 4 commits intomainfrom
add-memspace
Open

Add catalyst.memspace attribute#2750
mehrdad2m wants to merge 4 commits intomainfrom
add-memspace

Conversation

@mehrdad2m
Copy link
Copy Markdown
Contributor

Context:
Implements a generic memory-space attribute in the Catalyst dialect that can be used in the memory_space slot of memref types (or as a discardable attribute) to tag values with a logical memory domain plus an optional LLVM-level address space within that domain.
e.g.

memref<4x64xi8, #catalyst.memspace<"d0">>
memref<1xi32,   #catalyst.memspace<"d1", 1 : i64>>

Description of the Change:

Benefits:

Possible Drawbacks:

Related GitHub Issues:
[sc-117605]

@mehrdad2m mehrdad2m requested a review from rniczh April 24, 2026 17:29
@github-actions
Copy link
Copy Markdown
Contributor

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md on your branch with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@mehrdad2m mehrdad2m requested a review from josephleekl April 24, 2026 17:30
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.99%. Comparing base (ca2c62b) to head (3051667).
⚠️ Report is 17 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2750      +/-   ##
==========================================
- Coverage   97.07%   96.99%   -0.08%     
==========================================
  Files         164      165       +1     
  Lines       18703    18460     -243     
  Branches     1766     1783      +17     
==========================================
- Hits        18156    17906     -250     
- Misses        397      398       +1     
- Partials      150      156       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant