Skip to content

Assemble Ops (nWires, nParams) in ResourceAnalysis and RegisterDecompRuleResource passes#2755

Merged
maliasadi merged 16 commits intomainfrom
add_op_data_rdrr
Apr 27, 2026
Merged

Assemble Ops (nWires, nParams) in ResourceAnalysis and RegisterDecompRuleResource passes#2755
maliasadi merged 16 commits intomainfrom
add_op_data_rdrr

Conversation

@maliasadi
Copy link
Copy Markdown
Member

@maliasadi maliasadi commented Apr 24, 2026

Context:
Include Ops (nWires, nParams) in ResourceAnalysis and RegisterDecompRuleResource passes. We primarily need this info for the graph-decomposition pass; GraphBuilder & Solver use this info to find the most "optimized" decomposition pathway.

Description of the Change:

Benefits:

  • number of params information is available along with number of wires and adjoint for Ops visited by ResourceAnalysis and RegisterDecompRuleResource passes

Possible Drawbacks:

Related GitHub Issues:
[sc-117856]

@maliasadi maliasadi requested review from kipawaa and sengthai April 24, 2026 21:38
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.98%. Comparing base (1e784d7) to head (ca1a614).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2755      +/-   ##
==========================================
- Coverage   97.15%   96.98%   -0.18%     
==========================================
  Files          36      165     +129     
  Lines        4295    18460   +14165     
  Branches        0     1783    +1783     
==========================================
+ Hits         4173    17904   +13731     
- Misses        122      399     +277     
- Partials        0      157     +157     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread mlir/lib/Quantum/Transforms/graph_decomposition.cpp Outdated
@maliasadi maliasadi added this to the delightning milestone Apr 27, 2026
@maliasadi maliasadi requested a review from sengthai April 27, 2026 18:47
Copy link
Copy Markdown
Contributor

@sengthai sengthai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good to me! Thanks @maliasadi 👍

Comment thread mlir/lib/Quantum/Transforms/graph_decomposition.cpp Outdated
Comment thread mlir/test/Catalyst/RegisterDecompRuleResourceTest.mlir
Comment thread mlir/lib/Quantum/Transforms/graph_decomposition.cpp Outdated
@maliasadi maliasadi requested a review from kipawaa April 27, 2026 20:35
Copy link
Copy Markdown
Contributor

@kipawaa kipawaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@maliasadi maliasadi merged commit c9e769b into main Apr 27, 2026
40 checks passed
@maliasadi maliasadi deleted the add_op_data_rdrr branch April 27, 2026 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants