Accelerate PBC layer commutation with symplectic bases - #3095
Open
jk20342 wants to merge 4 commits into
Open
Conversation
|
Thanks @jk20342, this looks like an efficient representation for the PBC layer, leading to a significant speedup. We will review shortly and get back to you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context:
PBCLayerchecked a candidate against every operation already in the layerthis repeated Pauli normalization and became quadratic for large commuting layers
Description of the Change:
Benefits:
Possible Drawbacks:
None off the top of my head
Related GitHub Issues:
None