Skip to content

chore: remove wires from GlobalPhase call - #3108

Open
andrijapau wants to merge 2 commits into
mainfrom
fix/dont-use-wires-for-gp
Open

chore: remove wires from GlobalPhase call#3108
andrijapau wants to merge 2 commits into
mainfrom
fix/dont-use-wires-for-gp

Conversation

@andrijapau

@andrijapau andrijapau commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Context:

Exploring the impact if we merged PennyLaneAI/pennylane#9992

Description of the Change:

Benefits:

Possible Drawbacks:

Related GitHub Issues:

[sc-127745]

@andrijapau andrijapau changed the title remove wires from GlobalPhase call chore: remove wires from GlobalPhase call Aug 11, 2026
@JerryChen97

Copy link
Copy Markdown
Contributor

So it looks like in Catalyst no one truly cares about the wires of GlobalPhase? lol

@codecov

codecov Bot commented Aug 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.92%. Comparing base (f80ac8b) to head (643ca78).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3108   +/-   ##
=======================================
  Coverage   96.92%   96.92%           
=======================================
  Files         166      166           
  Lines       19142    19142           
  Branches     1815     1815           
=======================================
  Hits        18553    18553           
  Misses        430      430           
  Partials      159      159           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JerryChen97 JerryChen97 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. Remember to add a changelog since it changes builtin_passes.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants