Skip to content

[GOID] Use unified printing for parameter types - #3191

Open
dime10 wants to merge 1 commit into
minimal-single-sourcefrom
type-printing-is-ssot
Open

[GOID] Use unified printing for parameter types#3191
dime10 wants to merge 1 commit into
minimal-single-sourcefrom
type-printing-is-ssot

Conversation

@dime10

@dime10 dime10 commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Small follow-up on #3188 to remove the manual Python -> MLIR type conversion and manual string serialization of MLIR types for the GraphOpID format. Instead the Python binding utilities are used and the MLIR attribute printer handles the string serialization.

As a side-effect, more types are supported now that weren't present in the table (e.g. uint).

@dime10
dime10 requested review from kipawaa and paul0403 September 4, 2026 21:25
@dime10 dime10 changed the title [GOID] Use unified printing for the static data portion [GOID] Use unified printing for parameter types Sep 4, 2026
@codecov

codecov Bot commented Sep 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.69%. Comparing base (46f1fa8) to head (0ba3196).

Additional details and impacted files
@@                    Coverage Diff                    @@
##           minimal-single-source    #3191      +/-   ##
=========================================================
+ Coverage                  95.61%   95.69%   +0.08%     
=========================================================
  Files                        177      177              
  Lines                      20853    20857       +4     
  Branches                    2097     2096       -1     
=========================================================
+ Hits                       19938    19959      +21     
+ Misses                       726      712      -14     
+ Partials                     189      186       -3     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dime10
dime10 added this pull request to stack #3207 September 9, 2026 21:31
@dime10
dime10 force-pushed the type-printing-is-ssot branch from 0ba3196 to a240b49 Compare September 9, 2026 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant