[GOID] Use unified printing for parameter types - #3191
Open
dime10 wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## minimal-single-source #3191 +/- ##
=========================================================
+ Coverage 95.61% 95.69% +0.08%
=========================================================
Files 177 177
Lines 20853 20857 +4
Branches 2097 2096 -1
=========================================================
+ Hits 19938 19959 +21
+ Misses 726 712 -14
+ Partials 189 186 -3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
dime10
added this pull request to stack #3207
September 9, 2026 21:31
dime10
force-pushed
the
type-printing-is-ssot
branch
from
September 9, 2026 21:35
0ba3196 to
a240b49
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small follow-up on #3188 to remove the manual Python -> MLIR type conversion and manual string serialization of MLIR types for the GraphOpID format. Instead the Python binding utilities are used and the MLIR attribute printer handles the string serialization.
As a side-effect, more types are supported now that weren't present in the table (e.g. uint).