Only set has_branches=True for cond/switch without resource hint - #3195
Open
dwierichs wants to merge 4 commits into
Open
Only set has_branches=True for cond/switch without resource hint#3195dwierichs wants to merge 4 commits into
has_branches=True for cond/switch without resource hint#3195dwierichs wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context:
We introduced resource hints in #3059 and #3060, which allow to estimate the probability with which the predicate of a
condfires.In general, if there is a
cond, the metadatahas_branchesof the resources objects is set totrue, to enable PennyLane to raise a warning about the default union/max behaviour across branches.If we are using the resource hint, we don't want that warning, so we should not set
has_branchestotrueDescription of the Change:
Fix the above by stopping to set
has_branchestotrueif resource hints are present.Benefits:
Only warn if adequate.
Possible Drawbacks:
one could consider a renaming of the attribute, to something like
has_unestimated_branchesor so, but that would temporarily break PL CI, which we don't want for this tiny change.Related GitHub Issues: