Add ability to lower None as a compilable attribute value - #3196
Open
albi3ro wants to merge 5 commits into
Open
Conversation
albi3ro
commented
Sep 8, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3196 +/- ##
==========================================
+ Coverage 95.61% 95.64% +0.02%
==========================================
Files 177 177
Lines 20854 20856 +2
Branches 2100 2101 +1
==========================================
+ Hits 19939 19947 +8
+ Misses 726 722 -4
+ Partials 189 187 -2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
dime10
approved these changes
Sep 8, 2026
mehrdad2m
approved these changes
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[sc-129640]
Context:
Changes performed by cursor.
The compilable argument
indicestoSumOfSlatersPrepcan be tricky to find the right values for. We are going to want to be able to perform resource analysis onSumOfSlatersPrepwith unknown values forindices. We don't have the ability yet to perform resource analysis without a truly valid decomposition rule, but we will probably add this support soon,.In the meantime, we want to be able to at least capture and lower
SumOfSlatersPrepwith unknown indices, even if we can't do anything with it yet.Description of the Change:
Adds the ability to lower
Noneto a null value in MLIR.Benefits:
Unblocks resource estimation on ops with unknown attributes in the future.
Together with changes in PL, I am able to do:
Possible Drawbacks:
We could also represent "missing" attributes by just omitting them from the mlir. This is another way of dealing with null valued attributes in MLIR. But I think I prefer explicilty having it for now.
I'm trying to find a good discussion around using
NoneTypeversus omitting the attribute versus something else, but I can't seem to find anything besides what Gemini is telling me.Related GitHub Issues: