This repository was archived by the owner on Feb 5, 2024. It is now read-only.
Add PauliRot native cuQuantum support
#35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello. You may have forgotten to update the changelog!
|
mlxd
reviewed
Jun 23, 2022
Member
mlxd
left a comment
mlxd
left a comment
There was a problem hiding this comment.
Great job putting this together @maliasadi
Just one or two comments, but nothing major blocking .
Contributor
|
Hi @maliasadi. Nice work! I just have a few questions. |
Member
|
Hi @maliasadi , Great job and thanks for putting this together! Just a few minor comments. |
Member
|
Hey @maliasadi do you think this is ready to go? |
Member
Author
Let me commit the last batch of code review suggestions and it should be ready to go. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
This PR adds
PauliRotnative cuQuantum support to Lightning-GPU.Description of the Change:
Benefits:
Possible Drawbacks:
Related GitHub Issues: