Group circuits and execute in a single job - #660
Open
felipelewyee wants to merge 3 commits into
Open
Conversation
… of sampler_circuits, and execute them using a single PUB for each primitive. This avoids having to queue again between each circuit execution. The code affected is in functions *execute*, *_execute_sampler* and *_execute_estimator* in qiskit_device.py Test functions *test_execute_estimator_mocked* and *test_execute_pipeline_with_all_execute_types_mocked* in tests/test_base_device.py have been changed to reflect that _execute_estimator and _execute_sampler now returns a tuple of tuples with results.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #660 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 9 9
Lines 863 893 +30
=========================================
+ Hits 863 893 +30 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
felipelewyee
changed the title
felipelewyee
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR group circuits into a list of estimator_circuits and a list of sampler_circuits, and executes them in a single job for each primitive.
This avoids having to queue circuits individually between each execution.
What problem does this solve?
The current behavior is to sequentially execute each circuit as an individual job; hence, having to wait in the queue between each circuit execution. With this PR, all circuits are queued on the same job, avoiding the intermediate waiting.
Summary of changes
The code affected is in functions execute, _execute_sampler, and _execute_estimator in qiskit_device.py
Test functions test_execute_estimator_mocked and test_execute_pipeline_with_all_execute_types_mocked in tests/test_base_device.py have been changed to reflect that _execute_estimator and _execute_sampler now return a tuple with many results.