Skip to content

fix: update after ControlledPhaseShift produces GlobalPhase in decomp - #717

Open
andrijapau wants to merge 3 commits into
sc-127668-runnersfrom
fix/ll
Open

fix: update after ControlledPhaseShift produces GlobalPhase in decomp#717
andrijapau wants to merge 3 commits into
sc-127668-runnersfrom
fix/ll

Conversation

@andrijapau

@andrijapau andrijapau commented Aug 13, 2026

Copy link
Copy Markdown
Contributor
  • What happened

ControlledPhaseShift is now an Operator2 whose decomposition now has GlobalPhase in it.

  • Why it failed

The test is asserting that the decomposed ops below in QISKIT_OPERATION_MAP (which excludes GlobalPhase). However, the device accepts GlobalPhase as it is explcitly added in device.operations. E2E execution isn't affected.

  • Fix

Simply improve the test,

- assert np.all([op.name in QISKIT_OPERATION_MAP for op in tapes[0].operations])
+ assert np.all([op.name in test_dev.operations for op in tapes[0].operations])

@andrijapau
andrijapau changed the base branch from master to sc-127668-runners August 13, 2026 17:42
@codecov

codecov Bot commented Aug 13, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (c77e314) to head (84b3638).

Additional details and impacted files
@@                 Coverage Diff                 @@
##           sc-127668-runners      #717   +/-   ##
===================================================
  Coverage             100.00%   100.00%           
===================================================
  Files                      9         9           
  Lines                    873       873           
===================================================
  Hits                     873       873           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant