-
Notifications
You must be signed in to change notification settings - Fork 677
[Decomposition] Clean up custom logic for adjoint and pow #7352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o symbolic-rules-01
…o symbolic-rules-01
Hello. You may have forgotten to update the changelog!
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7352 +/- ##
========================================
Coverage 99.69% 99.69%
========================================
Files 537 537
Lines 50954 51197 +243
========================================
+ Hits 50799 51042 +243
Misses 155 155 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: Pietropaolo Frisoni <[email protected]>
Co-authored-by: Pietropaolo Frisoni <[email protected]>
…o conditional-decomp
JerryChen97
reviewed
May 15, 2025
Co-authored-by: Pietropaolo Frisoni <[email protected]>
…o conditional-decomp
…o symbolic-rules-02
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
This is a follow-up PR to #7347
Description of the Change:
There was previously a lot of custom logic for retrieving decomposition rules of symbolic operators. With the infrastructure added in #7347, this PR is able to clean up most of it.
Hadamard
was previously hardcoded as an operator that is its own adjoint, now there is a decomposition rule for"Adjoint(Hadamard)"
which produces an instance of the base operator."Pow(SomeOp)"
. All operators in PL which overridespow
now has a custom decomposition rule registered under the power of itself.self_adjoint
decomposition rule is defined, and it is registered with all operators that are self-adjoint (to avoid having duplicate code)Related Shortcut Stories:
[sc-90114]