-
Notifications
You must be signed in to change notification settings - Fork 677
Transform to convert to MBQC formalism #7355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Isaac De Vlugt <[email protected]>
Co-authored-by: Isaac De Vlugt <[email protected]>
Co-authored-by: Joey Carter <[email protected]>
Co-authored-by: Yushao Chen (Jerry) <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might help, though ugly
P.S. no it didn't
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job @lillian542
Nothing further from me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just one more good-to-have comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @lillian542 for the nice work. Just wondering why qml.math is preferred over qml.numpy or numpy here.
Context:
We have a transform to go from an arbitrary circuit to the gateset compatible with textbook MBQC. Now we want to convert that the MBQC formalism, expressed using resource states, parametrized MCMs and byproduct corrections.
Description of the Change:
We add a transform that performs a simple conversion from that gate-set to the MBQC formalism. "Simple" here means:
This is a very direct, naive conversion to the MBQC formalism. But it does the thing, so it's a good place to start - and we can use it as a baseline for quantifying future improvements in our circuit conversion.
Benefits:
We can convert a circuit to a simple, un-optimized implementation of the same circuit in the MBQC formalism.
[sc-88533]