-
Notifications
You must be signed in to change notification settings - Fork 657
Improved decomposition of DiagonalQubitUnitary
#7370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dwierichs
wants to merge
60
commits into
master
Choose a base branch
from
better-diag-decomp
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Korbinian Kottmann <[email protected]>
Co-authored-by: Isaac De Vlugt <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7370 +/- ##
==========================================
- Coverage 99.65% 99.65% -0.01%
==========================================
Files 529 529
Lines 50610 50603 -7
==========================================
- Hits 50434 50427 -7
Misses 176 176 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
DiagonalQubitUnitary
DiagonalQubitUnitary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
A diagonal unitary operator can be decomposed iteratively into
RZ
multiplexers (SelectPauliRot
) and a global phase.PennyLane is not using this quite established decomposition yet.
Similar to the
QubitUnitary
decomposition implemented in #7277, the method implemented here stems from Shende et al. (2004).It uses fewer CNOTs that the current implementation, but has larger classical computing/memory cost.
Description of the Change:
Replace current decomposition of
DiagonalQubitUnitary
by multiplexer-based decomposition.Also fixes a validation in
__init__
ofSelectPauliRot
to allow for parameter broadcasting.Benefits:
Quantumly cheaper decomposition of
DiagonalQubitUnitary
.Possible Drawbacks:
Increase classical computing /memory cost if the decomposition is carried out down to elementary gates (due toSelectPauliRot
decomposition).This increased classical cost is remedied by #7377
Related GitHub Issues:
[sc-90706]