Conversation
Contributor
|
Hello. You may have forgotten to update the changelog!
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9574 +/- ##
=======================================
Coverage 99.44% 99.45%
=======================================
Files 614 614
Lines 67863 67863
=======================================
+ Hits 67489 67490 +1
+ Misses 374 373 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
JerryChen97
approved these changes
Jun 3, 2026
Contributor
JerryChen97
left a comment
There was a problem hiding this comment.
Ahhhhh I actually can't believe this didn't cause any catastrophic cascading problems in our tests 😓
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context:
Fix a small bug in the way gate types in specs are accumulated
Test is co-written by yours truly, Jukebox (Claude)
Description of the Change:
Small fix so same gate types don't get overwritten
Benefits:
Fixes bug
Possible Drawbacks:
Related GitHub Issues: