Skip to content

Fix a small bug in the way gate types in specs are accumulated#9574

Open
Qottmann wants to merge 5 commits into
mainfrom
fixspecs
Open

Fix a small bug in the way gate types in specs are accumulated#9574
Qottmann wants to merge 5 commits into
mainfrom
fixspecs

Conversation

@Qottmann
Copy link
Copy Markdown
Contributor

@Qottmann Qottmann commented Jun 3, 2026

Context:
Fix a small bug in the way gate types in specs are accumulated

Test is co-written by yours truly, Jukebox (Claude)

Description of the Change:

Small fix so same gate types don't get overwritten

Benefits:

Fixes bug

Possible Drawbacks:

Related GitHub Issues:

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 3, 2026

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.45%. Comparing base (2e795d5) to head (e78e285).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9574   +/-   ##
=======================================
  Coverage   99.44%   99.45%           
=======================================
  Files         614      614           
  Lines       67863    67863           
=======================================
+ Hits        67489    67490    +1     
+ Misses        374      373    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

@JerryChen97 JerryChen97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahhhhh I actually can't believe this didn't cause any catastrophic cascading problems in our tests 😓

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants