refactor: promote RZ / CRZ / SelectPauliRot phase gradient decomps to transforms/decompositions - #9928
Open
andrijapau wants to merge 22 commits into
Open
refactor: promote RZ / CRZ / SelectPauliRot phase gradient decomps to transforms/decompositions#9928andrijapau wants to merge 22 commits into
RZ / CRZ / SelectPauliRot phase gradient decomps to transforms/decompositions#9928andrijapau wants to merge 22 commits into
Conversation
andrijapau
added
WIP 🚧
…nnyLaneAI/pennylane into refactor/move-labs-phase-grad-decomps
andrijapau
changed the title
RZ/CRZ/SelectPauliRot phase gradient decomps to transforms/decompositions
andrijapau
changed the title
RZ/CRZ/SelectPauliRot phase gradient decomps to transforms/decompositionsRZ / CRZ / SelectPauliRot phase gradient decomps to transforms/decompositions
andrijapau
changed the title
RZ / CRZ / SelectPauliRot phase gradient decomps to transforms/decompositionsRZ / CRZ / SelectPauliRot phase gradient decomps to transforms/decompositions
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9928 +/- ##
========================================
Coverage 99.46% 99.46%
========================================
Files 605 608 +3
Lines 67423 67552 +129
========================================
+ Hits 67059 67191 +132
+ Misses 364 361 -3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
andrijapau
commented
Jul 30, 2026
Contributor
Author
There was a problem hiding this comment.
Had to add additional test coverage
dwierichs
requested changes
Jul 30, 2026
dwierichs
left a comment
dwierichs
left a comment
Contributor
There was a problem hiding this comment.
Just some minor stuff :)
| @@ -226,17 +226,14 @@ def _resource_fn(num_wires, rot_axis): | |||
| match rot_axis: | |||
| case "X": | |||
| change_basis_rep_basis_adapted = change_op_basis_resource_rep( | |||
| qp.Hadamard, change_basis_rep, qp.Hadamard | |||
| qp.Hadamard, change_basis_rep, _adjoint_abstract(qp.Hadamard) | |||
Contributor
Author
There was a problem hiding this comment.
Sorry, yeah we no longer need this.
|
|
||
| # This should verify the decomp structure annd make sure that the resources match the | ||
| # decomposition, giving us enough coverage | ||
| _test_decomposition_rule(op, custom_decomp) |
Contributor
There was a problem hiding this comment.
This does not change whether the basis change is the wrong way around, for example.
Might be worth to actually go for some numerical test? 🤔
Coverage is way better already with this PR, so it almost feels like a nit pick 😅
Contributor
Author
There was a problem hiding this comment.
Let me think of a better way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context:
These decompositions are used in OFC workflows and should therefore be CI tested during any migration.
Description of the Change:
Promote them out of
labs.Benefits: CI/CD tested.
Possible Drawbacks: None that I am aware of.
[sc-126092]