Skip to content

QML Pipeline Improvements #1322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 140 commits into from
May 7, 2025
Merged

QML Pipeline Improvements #1322

merged 140 commits into from
May 7, 2025

Conversation

brownj85
Copy link
Contributor

@brownj85 brownj85 commented Feb 28, 2025

Context

Target branch for development on the v2 pipeline.

This pull request includes various changes to improve the build and deployment processes, update documentation, and manage dependencies more effectively. The most important changes include updates to GitHub workflow files, enhancements to the qml tool, and updates to the README and dependency files.

V2 PR comments are disabled.

@Alan-eMartin Alan-eMartin marked this pull request as ready for review May 1, 2025 18:37
@Alan-eMartin Alan-eMartin requested a review from rashidnhm May 1, 2025 18:48
Copy link
Collaborator

@ashishks0522 ashishks0522 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good and does not seem to impact any existing workflows. Approving to move this PR along, will defer to @rashidnhm for technical review of the actions.

Copy link
Collaborator

@rashidnhm rashidnhm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this still only looking at demonstrations_v2

... As new demos are added, will this actually build them?

From look at here it seems this is still only v2?

Should we hold this PR until #1361 is merged?

@Alan-eMartin
Copy link
Collaborator

Is this still only looking at demonstrations_v2

... As new demos are added, will this actually build them?

From look at here it seems this is still only v2?

Yep @rashidnhm — That is correct, we are still only looking at the demostrations_v2 directory. If new demos are added to the original directory (demonstrations) they will not be built. We will run a sync closer to release? Does that sound good?

@Alan-eMartin Alan-eMartin requested a review from rashidnhm May 7, 2025 15:02
@rashidnhm
Copy link
Collaborator

Yep @rashidnhm — That is correct, we are still only looking at the demostrations_v2 directory. If new demos are added to the original directory (demonstrations) they will not be built. We will run a sync closer to release? Does that sound good?

Yup, was just ensuring we are aware of it

@Alan-eMartin
Copy link
Collaborator

Yep @rashidnhm — That is correct, we are still only looking at the demostrations_v2 directory. If new demos are added to the original directory (demonstrations) they will not be built. We will run a sync closer to release? Does that sound good?

Yup, was just ensuring we are aware of it

Appreciate the extra set of eyes! Thank you @rashidnhm

Copy link
Contributor

@doctorperceptron doctorperceptron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @Alan-eMartin ! 🥳 Just some minor stuff, otherwise good to go.

@Alan-eMartin Alan-eMartin merged commit a5081f2 into master May 7, 2025
16 checks passed
@Alan-eMartin Alan-eMartin deleted the v2 branch May 7, 2025 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants