SC-85410 | V2 demos build on schedule #1358
Conversation
…1352) ### Goal: - To create timely PR previews when contributing or updating demos. --- ### Summary: This pull request uses the new `v2-build-demos` and `v2-deploy-demos` workflows to: 1. Build "modified" and new demos. 2. Save them as artifacts. 3. Deploy to the SWC database as previews. 4. Post a comment with preview links. --- ### Other changes: - Improved descriptions of inputs for workflows. --- ### Testing: I was required to fork the QML repo to push these workflows to `master` as `workflow_run` uses the workflow context from `master`. Therefore, you can take a look at the following ran actions: https://github.com/Alan-eMartin/qml/actions <img width="776" alt="Screenshot 2025-04-23 at 2 55 06 PM" src="https://github.com/user-attachments/assets/06273e69-ea21-4162-aed7-2181e7aabfae" /> --------- Co-authored-by: Paul Finlay <[email protected]>
Alan-eMartin
requested review from
doctorperceptron,
jontoye,
rashidnhm and
ashishks0522
Alan-eMartin
changed the title
Alan-eMartin
force-pushed
the
sc-85410-v2-demos-are-built-on-schedule
branch
from
7649946 to
3dd017d
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| uses: ./.github/workflows/v2-build-demos.yml | ||
| with: | ||
| ref: build-branch-dev | ||
| dev: true | ||
| save-artifact: true | ||
| artifact-name: build-branch-dev | ||
| keep-going: false | ||
| quiet: false | ||
| batch_size: 10 |
Check warning
Code scanning / CodeQL
Workflow does not contain permissions Medium
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI about 5 hours ago
To fix the issue, we will add a permissions block at the root level of the workflow. This block will define the minimal permissions required for the workflow to function securely. Based on the provided details, the workflow likely only needs contents: read permissions, as it appears to be a build process that does not modify repository contents or interact with other GitHub features.
| @@ -1,2 +1,4 @@ | ||
| name: V2 Build QML Branch - Dev | ||
| permissions: | ||
| contents: read | ||
| on: |
| uses: ./.github/workflows/v2-build-demos.yml | ||
| with: | ||
| ref: build-branch-master | ||
| dev: false | ||
| save-artifact: true | ||
| artifact-name: build-branch-master | ||
| keep-going: false | ||
| quiet: false | ||
| batch_size: 10 |
Check warning
Code scanning / CodeQL
Workflow does not contain permissions Medium
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI about 5 hours ago
To fix the issue, we will add a permissions block at the root level of the workflow. This block will define the least privileges required for the workflow to function. Since the workflow appears to be a build process, it likely only needs contents: read to access the repository's code. If additional permissions are required, they can be added based on the specific needs of the workflow.
| @@ -1,2 +1,4 @@ | ||
| name: V2 Build QML Branch - Dev | ||
| permissions: | ||
| contents: read | ||
| on: |
| on: | ||
| workflow_dispatch: | ||
| schedule: | ||
| - cron: '0 0 * * 0,2,4,6' # At 00:00 on Sunday, Tuesday, Thursday, and Saturday. |
There was a problem hiding this comment.
Wondering why we're building on Saturday and Sunday? I know the core team works pretty hard but surely the Sunday build will be identical to the Saturday build no?
| @@ -0,0 +1,21 @@ | |||
| name: V2 Build QML Branch - Dev | |||
There was a problem hiding this comment.
| name: V2 Build QML Branch - Dev | |
| name: V2 Build QML Branch - Master |
Summary:
Workflows added to build the
masteranddevbranch on a bi-daily basis (every two days).Please note, we will need to check out the
devversion of the workflow once this change is merged todevAs seen here:
from
./workflows/v2-build-demos.yml->./workflows/v2-build-demos.yml@dev