Fix notebook converter #1360
Open
Fix notebook converter #1360
+6
−184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update notebook converter to remove setting author info. Fix cell_id ……issue.
Title:
Fix QML notebook converter
Summary:
The current QML converter is not working with newer jupyter notebooks due to them not having an id for each cell.
In addition, the way demo author information is stored in QML today is completely different to how it was stored back when this converter was first written.
This PR updates the notebook converter such that the author info is no longer needed, and the cell_id is used only if present, if missing it simply uses the cell number instead.
Relevant references:
[sc-90046]
Possible Drawbacks:
As per before, the generated demo can be passed to sphinx-build, which has been tested. But it likely will not be 100% up to standard of the Product team, but this converter should give the author a quick conversion base to work off of.
Related GitHub Issues:
None.