Conversation
|
👋 Hey, looks like you've updated some demos! 🐘 Don't forget to update the Please hide this comment once the field(s) are updated. Thanks! |
Your preview is ready 🎉!You can view your changes here
|
| print(resources) | ||
|
|
||
| ############################################################################## | ||
| # Here the :class:`~.pennylane.estimator.compact_hamiltonian.PauliHamiltonian` class is used to |
There was a problem hiding this comment.
I would like to know why this are the resources, something like: note that by default we decompose the target get_set [...]. There is probably another demo you can link for the basics of the resource estimation functionality
| # | ||
| # Polynomial Approximations of the Inverse Function | ||
| # ------------------------------------------------- | ||
| # The cost of QSVT is directly proportional to the degree of the polynomial transformation. More |
There was a problem hiding this comment.
I'd recommend to link the matrix inversion demo for more details
There was a problem hiding this comment.
I think that could clarify a bit better the concept of kappa, right now it is not very clear
| # | ||
| # Diagonal Matrices & the Walsh-Hadamard Transform | ||
| # ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | ||
| # Let's start with the :math:`D_{k}` operators. These are a list of diagonal operators where |
There was a problem hiding this comment.
The operator D_k is not diagonal, it is a block encoding of a diagonal matrix
There was a problem hiding this comment.
It becomes block diagonal when we include the multiplexer. But I guess my point is that each individual D_i is a diagonal operator no?
| # | | ||
| # | ||
| # .. figure:: ../_static/demonstration_assets/re_qsvt/WH_a.png | ||
| # :align: center | ||
| # :width: 90% | ||
| # :target: javascript:void(0) | ||
| # |
There was a problem hiding this comment.
We may not be using the best notation in the paper 🙈
To clarify, the U in this image is D_k in the previous circuit
You could change the names in the picture
| num_diag_wires = int(np.ceil(np.log2(size_diagonal))) | ||
| list_of_diagonal_ops = [] | ||
|
|
||
| for _ in range(num_diags): |
There was a problem hiding this comment.
[research question, ignore in the demo] Wait, is it me or we should be able to merge all the diagonals into just one? it seems the structure would easily merge 🤔
There was a problem hiding this comment.
its just CNOTs and RZ, I imagine it should be mergable!
Co-authored-by: ANT0N <39093564+AntonNI8@users.noreply.github.com> Co-authored-by: Guillermo Alonso-Linaje <65235481+KetpuntoG@users.noreply.github.com>
3 participants
Title:
A new demo using the resource estimation functionality for CFD example using QSVT.
Summary:
Relevant references:
Possible Drawbacks:
Related GitHub Issues:
estimatormodule)Algo Researcher:
Algo Software Dev:
QSVT, Resource Estimation, Matrix Inversion, CFD, Linear systems of equations,
(more details here)