Skip to content

Sanitize NTLM hostname to prevent path traversal and injection #1243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TristanInSec wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Sanitize NTLM hostname to prevent path traversal and injection #1243

Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
68abd12
Sanitize NTLM hostname to prevent path traversal and DoS
TristanInSec May 16, 2026
9c293a8
Warn when NTLM hostname is sanitized
TristanInSec May 18, 2026
ccf36b4
Use display() for sanitization notice so it shows at default verbosity
TristanInSec May 23, 2026
d21ee2d
Merge remote-tracking branch 'upstream/main' into fix/sanitize-ntlm-h…
TristanInSec May 23, 2026
c20060a
Refactor hostname sanitization into helpers/misc.py
TristanInSec Jun 2, 2026
09f3f82
Address review: make logger required, use .fail() for sanitization wa…
TristanInSec Jun 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions nxc/connection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
from datetime import datetime
import os
import re
import random
import sys
import contextlib
Expand Down Expand Up @@ -245,6 +246,10 @@ def proto_flow(self):
else:
self.logger.debug("Created connection object")
self.enum_host_info()
sanitized = re.sub(r'[^\w\-.]', '_', self.hostname)
if sanitized != self.hostname:
self.logger.warning(f"Hostname contains invalid characters (received: {self.hostname!r}), sanitized to: {sanitized!r}")

@NeffIsBack NeffIsBack May 23, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Warnings are not displayed by default if not run at verbose or debug level. Please use .display()

self.hostname = sanitized

# Construct the output file template using os.path.join for OS compatibility
base_log_dir = os.path.join(NXC_PATH, "logs")
Expand Down