Refactor the --database argument to comply with security checks#1259
Refactor the --database argument to comply with security checks#1259Dfte wants to merge 1 commit into
Conversation
|
Nice one, thanks for the PR! One day we should probably either do some stub function that does the error handling (similar to |
We already do, if any error occurs, the self.conn.lastError value is filled. We simply have to check that value every query |
Yeah but I meant that we substitute the normal query and do this |
Description
This PR modifies the --database option to comply with security checks such as checking if the self.conn.lastError value is set by tds.py at some point.
Type of change
Insert an "x" inside the brackets for relevant items (do not delete options)
Setup guide for the review
Screenshots (if appropriate):
Nothing changed:
Checklist:
Insert an "x" inside the brackets for completed and relevant items (do not delete options)
poetry run ruff check ., use--fixto automatically fix what it can)tests/e2e_commands.txtfile if necessary (new modules or features are required to be added to the e2e tests)