-
Notifications
You must be signed in to change notification settings - Fork 494
Update Ruff and Fix Linting #629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I'll have to run |
If they're considered "unstable" yeah, probably not a good idea to use them. Path is the new way to use files with Python, so we should move to that. |
Hmm okay maybe then it is worth to enable some of them. Haven't seen |
We should probably use PTH then as well. |
Description
The pinned ruff version is super old by now. This PR updates ruff to the newest version and fixes all new rules that have been selected.
This should probably be merged after 1.4.0 is released
Excluded Rules:
sys.exit
shadowing python build-inexit()
, which we have explicitly chose not to useType of change
Please delete options that are not relevant.
How Has This Been Tested?
coerce_plus and pfx auth were tested against GOAD, but before merging extensive testing should still be done.
Checklist:
poetry run python -m ruff check . --preview
, use--fix
to automatically fix what it can)