Skip to content

Add missing dependencies for GH Release workflow / Linux #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 29, 2025

Conversation

cmeans
Copy link

@cmeans cmeans commented Mar 29, 2025

Looked for a fix for the Linux target build:

  • Tried adding missing dependencies for the GH Release workflow for a Linux target, and added more complete set of headers, but no joy.
  • Adjusted approach to use cross.

agg23 added a commit that referenced this pull request Mar 29, 2025
@agg23
Copy link
Collaborator

agg23 commented Mar 29, 2025

Thank you for the PR! I didn't have automatic builds set up for PRs when you sent this, so I fixed that and created a PR just to run the build (it will hopefully run with any future changes on this PR). It seems that is change isn't sufficient: https://github.com/openaipin/adb_remote_auth/actions/runs/14147631030/job/39636880473?pr=4

@cmeans
Copy link
Author

cmeans commented Mar 29, 2025

Thank you for the PR! I didn't have automatic builds set up for PRs when you sent this, so I fixed that and created a PR just to run the build (it will hopefully run with any future changes on this PR). It seems that is change isn't sufficient: https://github.com/openaipin/adb_remote_auth/actions/runs/14147631030/job/39636880473?pr=4

Thanks...but yes, figured-out how to run the workflow from my fork, and see no improvement. Will keep at it as time permits.

@agg23 agg23 merged commit 3d04e95 into PenumbraOS:main Mar 29, 2025
3 checks passed
@cmeans cmeans deleted the fix-workflow-linux-build branch March 29, 2025 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants