feat: visible X close button on overlay notifications#464
Merged
garysheng merged 1 commit intoPeonPing:mainfrom Apr 14, 2026
Merged
feat: visible X close button on overlay notifications#464garysheng merged 1 commit intoPeonPing:mainfrom
garysheng merged 1 commit intoPeonPing:mainfrom
Conversation
|
@smurfy92 is attempting to deploy a commit to the Gary Sheng's projects Team on Vercel. A member of the Team first needs to authorize it. |
Adds a discoverable × button in the top-right corner of overlay notifications. Clicking the X or anywhere else on the overlay dismisses it the same way (reusing the existing dismiss handler). New config key: notification_close_button (default: true) Useful for users who want an obvious way to dismiss notifications without having to guess that clicking the body works. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
garysheng
force-pushed
the
feat/close-button
branch
from
fb4216b to
14b0ee8
Compare
garysheng
added a commit
that referenced
this pull request
Apr 14, 2026
- peon setup wizard (#465, closes #283) - session-based notification stacking (#463) - X close button on overlays (#464) - notification_title_marker config (#457) - expanded peon status (#461) - NSPanel overlay focus fix (#462) - overlay label + suppression fix (#460) - pack sync robustness (#453) - linux notify-send dismiss time (#455) - nix zsh module (#456) - Warcraft III Orc peon mapping fix in README EN/zh/ja (closes #333)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a discoverable `×` button in the top-right corner of overlay notifications (glass, sakura, jarvis themes). Helps users who don't realize the whole overlay is clickable to dismiss.
New config
Test plan
🤖 Generated with Claude Code