Fix bikeable service road classification#874
Merged
Merged
Conversation
lalver1
force-pushed
the
fix-service-paths
branch
from
5421450 to
d4812c3
Compare
Member
|
Looks good, but it will need to go after #870. So I am putting attaching |
Service roads are only recognized as bikeable if they also are tagged "bicycle=yes/permissive/designated." That is correct, however they should only show up as a road, not as a bike path. This commit changes the functional_class of bikeable service roads to unclassified, which is more appropriate given that they have the following characteristics: 25mph speed limit, 1 lane, parking allowed, and 27ft roadway width.
lalver1
force-pushed
the
fix-service-paths
branch
from
d4812c3 to
f255206
Compare
pull-request-size
Bot
added
size/XS
Member
|
Per our conversation with @gstonecipher, you should be good to rebase and we can merge it @lalver1 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set the
functional_classof bikeable service roads tounclassified.Service roads are only recognized as bikeable if they also are tagged
bicycle=yes/permissive/designated. That is correct, however they should only show up as a road, not as a bike path. This PR changes thefunctional_classof bikeable service roads to
unclassified, which is more appropriate given that they have the following characteristics: