refactor(ci): extract reusable workflow for deployment#496
Conversation
|
Note Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
🎉 Deployed to Cloudflare!
|
There was a problem hiding this comment.
Pull request overview
This PR refactors the deployment workflow by extracting deployment logic into a reusable workflow file that can be shared across repositories and monorepo setups.
Key changes:
- Created parameterized
reusable-deploy.ymlwith configurable inputs for build/deploy commands, artifact paths, and working directories - Simplified
build-and-deploy.ymlto call the reusable workflow with secrets - Added support for optional typecheck job that can be disabled
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
.github/workflows/reusable-deploy.yml |
New reusable workflow with parameterized inputs for deployment, supporting monorepo setups with customizable commands and paths |
.github/workflows/build-and-deploy.yml |
Simplified to call the reusable workflow, passing Cloudflare secrets and removing duplicated job definitions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Perdolique
force-pushed
the
refactor-ci-extract-reusable-workflow
branch
from
24d0d43 to
6757a85
Compare
|
@Perdolique I've opened a new pull request, #497, to work on those changes. Once the pull request is ready, I'll request review from you. |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Perdolique
force-pushed
the
refactor-ci-extract-reusable-workflow
branch
from
6901cb6 to
9535597
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Perdolique
force-pushed
the
refactor-ci-extract-reusable-workflow
branch
from
9535597 to
464cdfa
Compare
Perdolique
force-pushed
the
refactor-ci-extract-reusable-workflow
branch
from
464cdfa to
85f405e
Compare
- ♻️ Migrate deployment logic to reusable workflow from `.github` repo - 🗑️ Remove `vscodeintellicode` from recommended VS Code extensions - 🎯 Simplify `build-and-deploy.yml` by using shared workflow - 🔧 Pass Cloudflare secrets to reusable workflow
Perdolique
force-pushed
the
refactor-ci-extract-reusable-workflow
branch
from
85f405e to
7d88baa
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
🎯 What's cookin', homies?
This PR cleans up our CI/CD game by extracting the deployment workflow into a shared reusable workflow 🔥💪
🔧 Changes made
.githubrepo's reusable workflowbuild-and-deploy.ymlPerdolique/.github/.github/workflows/deploy.yml@mastervscodeintellicodefrom recommendations)💡 Why tho?
🧪 Testing
The workflow will be tested when this PR triggers the CI pipeline. It should: