fix(attachments:sandbox): fix the empty attachment bug on macos#20
Open
sassman wants to merge 1 commit into
Open
fix(attachments:sandbox): fix the empty attachment bug on macos#20sassman wants to merge 1 commit into
sassman wants to merge 1 commit into
Conversation
b258e7a to
961b2b1
Compare
when having a sandboxed app, and using NSOpenPanel for letting users the selecting a file, the attachments did contain sizeof file times zero bytes. Using the FileManager to access the file contents did solve the problem. Also the base64 and cutting off after n characters is now simplified
961b2b1 to
1ae371d
Compare
Collaborator
|
@sassman thanks for the PR. would you please provide some test scripts against it to prove it works, if possible? |
Collaborator
|
@sassman I can't build your code for these errors. Please let me know your thoughts. Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when having a sandboxed app, and using NSOpenPanel for letting users the selecting a file, the attachments did contain sizeof file times zero bytes.
Using the FileManager to access the file contents did solve the problem.
Also the base64 and cutting off after n characters is now simplified