Skip to content

fix: forward transition field in 12 AnimatableFilter subclasses #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
1Lucas1apk merged 1 commit into from
Aug 26, 2026
Merged

fix: forward transition field in 12 AnimatableFilter subclasses #227

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/playback/filters/chorus.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,8 @@ export default class Chorus extends AnimatableFilter {
super.applyAnimatedUpdate(
{
chorus: {
alpha: targetAlpha
alpha: targetAlpha,
transition: c.transition
}
},
'chorus',
Expand Down
3 changes: 2 additions & 1 deletion src/playback/filters/compressor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,8 @@ export default class Compressor extends AnimatableFilter {
super.applyAnimatedUpdate(
{
compressor: {
alpha: targetAlpha
alpha: targetAlpha,
transition: comp.transition
}
},
'compressor',
Expand Down
3 changes: 2 additions & 1 deletion src/playback/filters/distortion.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,8 @@ export default class Distortion extends AnimatableFilter {
super.applyAnimatedUpdate(
{
distortion: {
alpha: targetAlpha
alpha: targetAlpha,
transition: dist.transition
}
},
'distortion',
Expand Down
3 changes: 2 additions & 1 deletion src/playback/filters/echo.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,8 @@ export default class Echo extends AnimatableFilter {
super.applyAnimatedUpdate(
{
echo: {
alpha: targetAlpha
alpha: targetAlpha,
transition: e.transition
}
},
'echo',
Expand Down
3 changes: 2 additions & 1 deletion src/playback/filters/highpass.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,8 @@ export default class Highpass extends AnimatableFilter {
super.applyAnimatedUpdate(
{
highpass: {
targetAlpha: targetAlpha
targetAlpha: targetAlpha,
transition: rawConfig.transition
}
},
'highpass',
Expand Down
3 changes: 2 additions & 1 deletion src/playback/filters/karaoke.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,8 @@ export default class Karaoke extends AnimatableFilter {
super.applyAnimatedUpdate(
{
karaoke: {
alpha: targetAlpha
alpha: targetAlpha,
transition: k.transition
}
},
'karaoke',
Expand Down
3 changes: 2 additions & 1 deletion src/playback/filters/lowpass.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,8 @@ export default class Lowpass extends AnimatableFilter {
super.applyAnimatedUpdate(
{
lowpass: {
logSmoothing: targetLogSmoothing
logSmoothing: targetLogSmoothing,
transition: rawConfig.transition
}
},
'lowpass',
Expand Down
3 changes: 2 additions & 1 deletion src/playback/filters/phaser.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,8 @@ export default class Phaser extends AnimatableFilter {
super.applyAnimatedUpdate(
{
phaser: {
alpha: targetAlpha
alpha: targetAlpha,
transition: p.transition
}
},
'phaser',
Expand Down
3 changes: 2 additions & 1 deletion src/playback/filters/rotation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,8 @@ export default class Rotation extends AnimatableFilter {
super.applyAnimatedUpdate(
{
rotation: {
alpha: targetAlpha
alpha: targetAlpha,
transition: r.transition
}
},
'rotation',
Expand Down
3 changes: 2 additions & 1 deletion src/playback/filters/spatial.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,8 @@ export default class Spatial extends AnimatableFilter {
super.applyAnimatedUpdate(
{
spatial: {
alpha: targetAlpha
alpha: targetAlpha,
transition: s.transition
}
},
'spatial',
Expand Down
3 changes: 2 additions & 1 deletion src/playback/filters/tremolo.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,8 @@ export default class Tremolo extends AnimatableFilter {
super.applyAnimatedUpdate(
{
tremolo: {
alpha: targetAlpha
alpha: targetAlpha,
transition: t.transition
}
},
'tremolo',
Expand Down
3 changes: 2 additions & 1 deletion src/playback/filters/vibrato.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,8 @@ export default class Vibrato extends AnimatableFilter {
super.applyAnimatedUpdate(
{
vibrato: {
alpha: targetAlpha
alpha: targetAlpha,
transition: v.transition
}
},
'vibrato',
Expand Down
Loading