Fix/misc/clean up toasts #361
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sswordInput and AuthenticationEmailInput
Kept the Toast messages in the TODO section since they will be removed along with other unimplemented features in a future update.
3 tasks
…/clean-up-toasts # Conflicts: # app/src/main/java/com/android/periodpals/ui/map/Map.kt
|
Harrish92
approved these changes
Dec 20, 2024
There was a problem hiding this comment.
Summary
Good implementation of the feature that streamlines the user flow.
Important
Code Quality
- Code quality is consistent with the rest of the project.
Functionality
- The apps runs as intended.
Testing
- No tests needed.
Documentation
- No documentation needed.
Suggestions
- Read my review comments
- Remove unused toast text in
strings.xml.
Steps before PR approved
- LGTM
| @@ -183,7 +168,6 @@ fun CreateAlertScreen( | |||
| else -> null | |||
| } | |||
| if (errorMessage != null) { | |||
| Toast.makeText(context, errorMessage, Toast.LENGTH_SHORT).show() | |||
There was a problem hiding this comment.
add a Log.d for errorMessage
| @@ -177,15 +173,9 @@ fun EditAlertScreen( | |||
| else -> null | |||
| } | |||
| if (errorMessage != null) { | |||
| Toast.makeText(context, errorMessage, Toast.LENGTH_SHORT).show() | |||
There was a problem hiding this comment.
add a Log.d for errorMessage
coaguila
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up the toasts messages (UX oriented)
And task : Clean up the error messages (UX oriented #344
Description
This PR focuses on removing the use of
Toastmessages across the application and replacing them withLogstatements for improved user experience and debugging. It also includes code refactoring to eliminate unnecessary context parameters and handlers, enhancing code clarity and maintainability. I closes issue #343 and #344.Note: The toasts in the TODOs were not removed because they need to be addressed simultaneously in #346.
Changes
Files
Modified
AlertLists.kt: RemovedToastmessages inAlertListsScreenandAlertAcceptButtons, replaced withLogstatements.CreateAlert.kt: UpdatedToastmessages inCreateAlertScreentoLogstatements.EditAlert.kt: ReplacedToastmessages withLogstatements inEditAlertScreen.SignIn.kt: Removed context parameters and handlers forToastmessages inSignInScreenandattemptSignIn.SignUp.kt: Cleaned up context parameters and handlers inSignUpScreenandattemptSignUp.ProfileComponents.kt: Removed context parameters and handlers inProfileSaveButtonand related functions.AuthenticationComponents.kt: Enhanced error state handling for email and password input fields.Map.kt: ReplacedToastmessages inFetchAlertsAndDrawMarkerswithLogstatements.CreateProfile.kt: Removed unnecessary context parameters inCreateProfileScreen.Removed
Toastmessages and related context handlers.Dependencies Added
Testing
Logstatements function correctly and provide meaningful debugging information.Points to Consider
Toastmessages.